Skip to content

Add ParseStethoInterceptor #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 3, 2015
Merged

Add ParseStethoInterceptor #48

merged 4 commits into from
Sep 3, 2015

Conversation

wangmengyan95
Copy link
Contributor

Currently rely on manually test, using three http clients and check normal and GZIP response.

@wangmengyan95 wangmengyan95 added this to the 1.10.2 milestone Aug 23, 2015
grantland
grantland reviewed Aug 25, 2015
View reviewed changes
Parse/src/main/java/com/parse/ParseStethoInterceptor.java
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: newline at EOF

@grantland
Copy link
Contributor

LGTM, let's get Josh looking at this.

In addition, do you think we should put this and LogcatInterceptor in a separate module? That way developers don't have to ship this extra code, but can add another Maven dependency when they want to use it?

@grantland grantland assigned wangmengyan95 and unassigned grantland Aug 25, 2015
@wangmengyan95 wangmengyan95 force-pushed the wangmengyan.add_Stetho_interceptor branch from aed20c6 to bd7ddf7 Compare September 1, 2015 00:46
@wangmengyan95
Copy link
Contributor Author

Discuss offline, will split ParseLogInterceptor and ParseStethoInterceptor to a separate module.

grantland
grantland reviewed Sep 2, 2015
View reviewed changes
Parse/src/main/java/com/parse/ParseStethoInterceptor.java
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add license headers

wangmengyan95 added a commit that referenced this pull request Sep 3, 2015
@wangmengyan95
Merge pull request #48 from ParsePlatform/wangmengyan.add_Stetho_inte…
20a6818 
…rceptor

Add ParseStethoInterceptor
@wangmengyan95 wangmengyan95 merged commit 20a6818 into master Sep 3, 2015
@facebook-github-bot
Copy link

@wangmengyan95 updated the pull request.

@rogerhu rogerhu deleted the wangmengyan.add_Stetho_interceptor branch April 12, 2017 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@wangmengyan95 wangmengyan95

Labels
None yet
Projects
None yet
Milestone
1.10.2
Development

Successfully merging this pull request may close these issues.
3 participants
@wangmengyan95 @grantland @facebook-github-bot