Fix ParseUser#setState(state) unnecessarily creating authData #312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @wangmengyan95, @grantland and @hallucinogen to be potential reviewers. |
| @@ -1435,6 +1435,35 @@ public void testSetCurrentUserStateWithoutAuthData() throws Exception { | |||
| assertEquals("valueAgain", user.get("key")); | |||
| } | |||
|
|
|||
| @Test | |||
| public void testSetNoAuthDataCurrentUserStateWithoutAuthData() throws Exception { | |||
There was a problem hiding this comment.
testSetStateDoesNotAddNonExistentAuthData
grantland
added
the
type:bug
|
Some nits and can we rename the PR and commit to say so that we have a bit more context as to what this PR is about? |
wangmengyan95
changed the title
wangmengyan95
force-pushed
the
wangmengyan.fix_set_user_state_add_none_existed_authData_bug
branch
from
d04ecdf to
5e29947
Compare
|
@wangmengyan95 updated the pull request. |
facebook-github-bot
added
GH Review: review-needed
and removed
GH Review: needs-revision
labels
|
LGTM |
wangmengyan95
added a commit
that referenced
this pull request
Dec 21, 2015
…tate_add_none_existed_authData_bug Fix ParseUser#setState(state) unnecessarily creating authData
|
@wangmengyan95 updated the pull request. |
rogerhu
deleted the
wangmengyan.fix_set_user_state_add_none_existed_authData_bug
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing a bug that was introduced in #304 that caused
authDatato be created onParseUser#setState(state)with a state that did not containauthDatain the first place.