Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Conversation

@gui1117
Copy link
Contributor

@gui1117 gui1117 commented Sep 10, 2021

  • the features small_rng for rand in dev dependency is misswritten and never used (or is the feature about configuring a faster rng for tests ?)
  • some unneeded borrow of unit type was done (the type is &()).

@gui1117 gui1117 added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Sep 10, 2021
@bkchr
Copy link
Member

bkchr commented Sep 10, 2021

bot merge

@ghost
Copy link

ghost commented Sep 10, 2021

Waiting for commit status.

@ghost
Copy link

ghost commented Sep 10, 2021

Merge aborted: Checks failed for 511047a

@bkchr bkchr merged commit 63b32fb into master Sep 10, 2021
@bkchr bkchr deleted the gui-fix-state-machine branch September 10, 2021 14:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants