Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Run tests for the wasmer sandbox #9610

Merged
merged 4 commits into from
Aug 24, 2021
Merged

Run tests for the wasmer sandbox #9610

merged 4 commits into from
Aug 24, 2021

Conversation

@rcny
Copy link
Contributor

@rcny rcny commented Aug 23, 2021

@rcny rcny added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Aug 23, 2021
@rcny rcny self-assigned this Aug 23, 2021
@rcny rcny marked this pull request as ready for review August 23, 2021 18:34
@rcny rcny requested a review from a team as a code owner August 23, 2021 18:34
@rcny
Copy link
Contributor Author

rcny commented Aug 23, 2021

Tested, LGTM. Relevant CI job.

@rcny rcny requested review from athei and sergejparity August 23, 2021 20:47
athei
athei approved these changes Aug 24, 2021
View reviewed changes
Copy link
Member

@athei athei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

@rcny
Copy link
Contributor Author

rcny commented Aug 24, 2021

bot merge

@ghost
Copy link

ghost commented Aug 24, 2021

Error: When trying to meet the "Project Owners" approval requirements: this pull request does not belong to a project defined in Process.json.

Approval by "Project Owners" is only attempted if other means defined in the criteria for merge are not satisfied first.

The following errors might have affected the outcome of this attempt:

  • 'Benchmarking and Weights' does not match any projects in substrate's Process.json

@rcny
Copy link
Contributor Author

rcny commented Aug 24, 2021

bot merge force

@ghost
Copy link

ghost commented Aug 24, 2021

Error: When trying to meet the "Project Owners" approval requirements: this pull request does not belong to a project defined in Process.json.

Approval by "Project Owners" is only attempted if other means defined in the criteria for merge are not satisfied first.

The following errors might have affected the outcome of this attempt:

  • 'Benchmarking and Weights' does not match any projects in substrate's Process.json

@rcny
Copy link
Contributor Author

rcny commented Aug 24, 2021 •
edited
Loading

IMO it would be nice to have a project owner for CI.

@rcny rcny merged commit 4172dfb into master Aug 24, 2021
@rcny rcny deleted the vi-run-tests-for-the-wasmer-sandbox branch August 24, 2021 10:22
Wizdave97 pushed a commit to Wizdave97/substrate that referenced this pull request Aug 25, 2021
@rcny @Wizdave97
Run tests for the wasmer sandbox (paritytech#9610)
0989d18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@athei athei athei approved these changes

@sergejparity sergejparity sergejparity approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rcny rcny

Labels

A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rcny @athei @sergejparity