This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Do not use Option to wrap GenesisConfig fields
#8275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we wrap every `GenesisConfig` field in an `Option`, while we require `Default` being implemented for all pallet genesisconfigs. Passing `None` also results in the genesis not being initialized, which is a bug as seen from the perspective of a pallet developer? This pr changes the fields of the `GenesisConfig` to non `Option` types.
bkchr
added
A0-please_review
gui1117
approved these changes
Mar 5, 2021
There was a problem hiding this comment.
The only usecase of this option is in case someone don't want to execute the genesis config of a pallet.
But I agree it doesn't seem very useful.
anyway code of this PR is good.
sidenote: we could also implement Default for the runtime GenesisConfig to allow ..Default::default() syntax
We already do this ;D |
shawntabrizi
approved these changes
Mar 6, 2021
|
bot merge force |
|
Trying merge. |
ghost
merged commit
ghost
pushed a commit
to paritytech/polkadot
that referenced
this pull request
Mar 6, 2021
* Substrate companion #8275 paritytech/substrate#8275 * "Update Substrate" Co-authored-by: parity-processbot <>
HCastano
added a commit
to paritytech/parity-bridges-common
that referenced
this pull request
Apr 6, 2021
Related Substrate PR: paritytech/substrate#8275
HCastano
added a commit
to paritytech/parity-bridges-common
that referenced
this pull request
Apr 7, 2021
* Bump Substrate * Change usage of "Module" to "Pallet" Related Substrate PR: paritytech/substrate#8372 * Add `OnSetCode` config param Related Substrate PR: paritytech/substrate#8496 * Update Aura Slot duration time type Related Substrate PR: paritytech/substrate#8386 * Add `OnSetCode` to mock runtimes * Add support for multiple justifications Related Substrate PR: paritytech/substrate#7640 * Use updated justification type in more places * Make GenesisConfig type non-optional Related Substrate PR: paritytech/substrate#8275 * Update service to use updated telemetry Related Substrate PR: paritytech/substrate#8143 * Appease Clippy
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we wrap every
GenesisConfigfield in anOption, whilewe require
Defaultbeing implemented for all pallet genesisconfigs.Passing
Nonealso results in the genesis not being initialized, whichis a bug as seen from the perspective of a pallet developer?
This pr changes the fields of the
GenesisConfigto nonOptiontypes.polkadot companion: paritytech/polkadot#2575