Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Conversation

@BTCB
Copy link

@BTCB BTCB commented May 31, 2020

substrate lesson1, I need send a pull request. I also only fmt the master branch code.

@parity-cla-bot
Copy link

It looks like @yunweb hasn't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence.
Wikipedia

You can read and sign our full Contributor License Agreement at the following URL: https://cla.parity.io

Once you've signed, please reply to this thread with [clabot:check] to prove it.

Many thanks,

Parity Technologies CLA Bot

@cecton
Copy link
Contributor

cecton commented Jun 2, 2020

Duplicated with #5456

We don't use rustfmt in Substrate.

Here you can find our style guide.

@jayzhan211
Copy link

What is the reason that Substrate don't use rustfmt?

@cecton
Copy link
Contributor

cecton commented Sep 3, 2020

Some people don't like the styling of rustfmt

@Demi-Marie
Copy link
Contributor

I wonder if rustfmt is configurable enough to match our style guide.

@cecton
Copy link
Contributor

cecton commented Sep 4, 2020

It might very well be now. It's been a long time. There is an issue about exactly that somewhere actually.

@jayzhan211
Copy link

It might very well be now. It's been a long time. There is an issue about exactly that somewhere actually.

I hope we can reconsider using rustfmt. 👍

@cecton
Copy link
Contributor

cecton commented Sep 8, 2020

Found it: #286

@kianenigma
Copy link
Contributor

also #2156

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants