Move sc-client into sc-service

[seunlanlege]

see #4452

[parity-cla-bot]

It looks like @seunlanlege signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

[seunlanlege]

EXPECTED:
┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈
error: Error type can not change between runtime apis
  --> $DIR/mock_only_one_error_type.rs:23:3
   |
23 |         type Error = u64;
   |         ^^^^
error[E0277]: the trait bound `u32: std::convert::From<std::string::String>` is not satisfied
  --> $DIR/mock_only_one_error_type.rs:15:1
   |
15 | / sp_api::mock_impl_runtime_apis! {
16 | |     impl Api<Block> for MockApi {
17 | |         type Error = u32;
18 | |
...  |
26 | |     }
27 | | }
   | | ^
   | | |
   | |_the trait `std::convert::From<std::string::String>` is not implemented for `u32`
   |   in this macro invocation
   |
   = help: the following implementations were found:
             <u32 as std::convert::From<bool>>
             <u32 as std::convert::From<char>>
             <u32 as std::convert::From<h2::frame::reason::Reason>>
             <u32 as std::convert::From<h2::frame::stream_id::StreamId>>
           and 16 others
┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈
ACTUAL OUTPUT:
┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈
error: Error type can not change between runtime apis
  --> $DIR/mock_only_one_error_type.rs:23:3
   |
23 |         type Error = u64;
   |         ^^^^
error[E0277]: the trait bound `u32: std::convert::From<std::string::String>` is not satisfied
  --> $DIR/mock_only_one_error_type.rs:15:1
   |
15 | / sp_api::mock_impl_runtime_apis! {
16 | |     impl Api<Block> for MockApi {
17 | |         type Error = u32;
18 | |
...  |
26 | |     }
27 | | }
   | | ^
   | | |
   | |_the trait `std::convert::From<std::string::String>` is not implemented for `u32`
   |   in this macro invocation
   |
   = help: the following implementations were found:
             <u32 as std::convert::From<bool>>
             <u32 as std::convert::From<char>>
             <u32 as std::convert::From<h2::frame::reason::Reason>>
             <u32 as std::convert::From<h2::frame::reason::Reason>>
           and 18 others
┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈
note: If the actual output is the correct output you can bless it by rerunning
      your test with the environment variable TRYBUILD=overwrite

note: If the actual output is the correct output you can bless it by rerunning
your test with the environment variable TRYBUILD=overwrite

So the library was updated and the stack frame has changed as a result, not sure how to go about this though.

[seunlanlege]

Also this:

thread 'main' panicked at 'unable to generate rocksdb bindings: ()', /ci-cache/substrate/cargo/check-web-wasm/registry/src/github.202132.xyz-1ecc6299db9ec823/librocksdb-sys-6.6.4/build.rs:30:20

[arkpar]

Impressive work. @seunlanlege Are there still any pending issues with this PR? If not, let's rebase and merge.

@svyatonik Could you please check if there are any potential issues with the light client changes?

[bkchr]

Same. Please bring it back.

[seunlanlege]

som'n weird going on in gitlab, will retry the jobs in an hr

[seunlanlege]

Polkadot companion PR is green 🎊 🥳

[bkchr]

Please make sure your polkadot changes work with cumulus.

[gnunicorn]

Thanks, this is a big step forwards. Let's please restrict the actual requirements a bit and make sure that we have a patch pending for cumulus if necessary.

[seunlanlege]

@gnunicorn is this eligible for a mergeoncegreen tag?

[gnunicorn]

lgtm

[gnunicorn]

bot merge

[bkchr]

So this works with cumulus?

[seunlanlege]

So this works with cumulus?

Will have a PR for cumulus ready soon.