This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Allow node to add externalities extensions #4583
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnunicorn
commented
Jan 9, 2020
bkchr
reviewed
Jan 10, 2020
bkchr
approved these changes
Jan 10, 2020
tomaka
approved these changes
Jan 10, 2020
|
Please merge master. |
gavofyork
added
A7-looksgoodcantmerge
and removed
A0-please_review
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, to make this work with the least code impact necessary (and without refactoring
ServiceBuilder), this takes a similar approach as we already use for theregister_transaction_poolfunction to expose it to the service builder, which can then in turn offer it to the outside.This change is necessary for external libraries (in this case Substrate-LFS) to provide further functionality through the externalities of a chain, so they can be used in e.g. Offchain-Workers.