This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Remove useless TryInto/TryFrom imports
#11136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because `TryInto`/`TryFrom` are in prelude by default from edition 2021 Signed-off-by: koushiro <[email protected]>
koushiro
requested review from
acatangiu,
andresilva,
athei,
kianenigma and
sorpaas
as code owners
kianenigma
approved these changes
Mar 29, 2022
athei
approved these changes
Mar 30, 2022
koushiro
changed the title
TryInto/TryFrom imports
ggwpez
added
A0-please_review
bkchr
approved these changes
Apr 3, 2022
|
PSA: if anyone is running into |
DaviRain-Su
pushed a commit
to octopus-network/substrate
that referenced
this pull request
Aug 23, 2022
Because `TryInto`/`TryFrom` are in prelude by default from edition 2021 Signed-off-by: koushiro <[email protected]>
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
Because `TryInto`/`TryFrom` are in prelude by default from edition 2021 Signed-off-by: koushiro <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
TryInto/TryFromare part of the prelude by default from edition 2021polkadot companion: paritytech/polkadot#5218