Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Conversation

@shawntabrizi
Copy link
Member

StorageDoubleMap has no magically efficient storage removal operation compared to an iterator which will remove all the storage items in the double map.

Users are getting confused like here: https://substrate.stackexchange.com/questions/1280/complexity-of-storagedoublemapremove-prefix/1285#1285

@github-actions github-actions bot added the A0-please_review Pull request needs code review. label Mar 27, 2022
@shawntabrizi shawntabrizi added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit and removed A0-please_review Pull request needs code review. labels Mar 27, 2022
@bkchr
Copy link
Member

bkchr commented Mar 27, 2022

bot merge

@paritytech-processbot
Copy link

Bot will approve on the behalf of @bkchr, since they are a team lead, in an attempt to reach the minimum approval count

@paritytech-processbot paritytech-processbot bot merged commit d26123a into master Mar 27, 2022
@paritytech-processbot paritytech-processbot bot deleted the shawntabrizi-update-docs branch March 27, 2022 06:43
grishasobol pushed a commit to gear-tech/substrate that referenced this pull request Mar 28, 2022
grishasobol pushed a commit to gear-tech/substrate that referenced this pull request Mar 28, 2022
grishasobol pushed a commit to gear-tech/substrate that referenced this pull request Mar 28, 2022
DaviRain-Su pushed a commit to octopus-network/substrate that referenced this pull request Aug 23, 2022
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants