Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Refactor Beefy MMR and remove parachain specific implementations #10664

Merged
merged 15 commits into from
Apr 1, 2022
Merged

Refactor Beefy MMR and remove parachain specific implementations #10664

merged 15 commits into from
Apr 1, 2022

Conversation

@Wizdave97
Copy link
Contributor

@Wizdave97 Wizdave97 commented Jan 14, 2022 •
edited
Loading

@Wizdave97 Wizdave97 marked this pull request as ready for review January 14, 2022 14:11
@Wizdave97 Wizdave97 requested a review from acatangiu as a code owner January 14, 2022 14:11
@Wizdave97 Wizdave97 mentioned this pull request Jan 14, 2022
Merged
seunlanlege
seunlanlege reviewed Jan 14, 2022
View reviewed changes
@Wizdave97
Copy link
Contributor Author

Polkadot companion has been updated, CI checks need to be restarted

acatangiu
acatangiu reviewed Jan 24, 2022
View reviewed changes
acatangiu
acatangiu approved these changes Jan 24, 2022
View reviewed changes
Copy link
Contributor

@acatangiu acatangiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, the code looks good, the leaf data is now generic 💯

@acatangiu acatangiu added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Jan 24, 2022
@acatangiu acatangiu force-pushed the david/refactor-beefy-mmr branch from 86d7912 to 488660d Compare January 25, 2022 12:02
@stale
Copy link

stale bot commented Feb 25, 2022

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the A5-stale Pull request did not receive any updates in a long time. No review needed at this stage. Close it. label Feb 25, 2022
@seunlanlege
Copy link
Contributor

Bump

@stale stale bot removed the A5-stale Pull request did not receive any updates in a long time. No review needed at this stage. Close it. label Feb 25, 2022
@stale
Copy link

stale bot commented Mar 27, 2022

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the A5-stale Pull request did not receive any updates in a long time. No review needed at this stage. Close it. label Mar 27, 2022
@acatangiu
Copy link
Contributor

bump

@stale stale bot removed the A5-stale Pull request did not receive any updates in a long time. No review needed at this stage. Close it. label Mar 28, 2022
@acatangiu acatangiu requested a review from svyatonik March 30, 2022 12:08
svyatonik
svyatonik approved these changes Mar 30, 2022
View reviewed changes
Copy link
Contributor

@svyatonik svyatonik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT. Have a couple of questions, though

@acatangiu acatangiu self-requested a review March 30, 2022 13:49
@Wizdave97 Wizdave97 force-pushed the david/refactor-beefy-mmr branch from 257ebda to c0c05b6 Compare March 31, 2022 11:15
Wizdave97
Wizdave97 commented Mar 31, 2022
View reviewed changes
acatangiu
acatangiu approved these changes Mar 31, 2022
View reviewed changes
acatangiu
acatangiu reviewed Mar 31, 2022
View reviewed changes
@acatangiu
Copy link
Contributor

@Wizdave97 cargo fmt test is still failing FYI

acatangiu
acatangiu reviewed Apr 1, 2022
View reviewed changes
@acatangiu
Copy link
Contributor

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 56dc6d1 into paritytech:master Apr 1, 2022
@Wizdave97 Wizdave97 deleted the david/refactor-beefy-mmr branch April 1, 2022 08:54
@acatangiu acatangiu mentioned this pull request Apr 1, 2022
Closed
DaviRain-Su pushed a commit to octopus-network/substrate that referenced this pull request Aug 23, 2022
@Wizdave97 @acatangiu @DaviRain-Su
Refactor Beefy MMR and remove parachain specific implementations (par…
b2637f3 
…itytech#10664)

* refactor beefy mmr

* use plain vector of bytes for leaf extra

* update comment

* update comments

* remove unused vars

* Use sp_std::vec::Vec

Co-authored-by: Adrian Catangiu <[email protected]>

* make extra data generic

* fix tests

* refactor beefy-mmr

* Update frame/beefy-mmr/src/lib.rs

* minor fix

* fmt

* Update frame/beefy-mmr/src/lib.rs

Co-authored-by: Adrian Catangiu <[email protected]>
@Wizdave97 Wizdave97 mentioned this pull request Oct 8, 2022
Merged
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
@Wizdave97 @acatangiu @ark0f
Refactor Beefy MMR and remove parachain specific implementations (par…
4e437a6 
…itytech#10664)

* refactor beefy mmr

* use plain vector of bytes for leaf extra

* update comment

* update comments

* remove unused vars

* Use sp_std::vec::Vec

Co-authored-by: Adrian Catangiu <[email protected]>

* make extra data generic

* fix tests

* refactor beefy-mmr

* Update frame/beefy-mmr/src/lib.rs

* minor fix

* fmt

* Update frame/beefy-mmr/src/lib.rs

Co-authored-by: Adrian Catangiu <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers

@seunlanlege seunlanlege seunlanlege left review comments

@acatangiu acatangiu acatangiu approved these changes

@svyatonik svyatonik svyatonik approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove parachains mentions from Substrate repository

4 participants

@Wizdave97 @seunlanlege @acatangiu @svyatonik