Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

try-runtime proper error types #13736

@kianenigma

Description

@kianenigma

The current try-runtime code paths are all using a very very rudimentary &'static str as the error type. Even worse, we don't really handle the error in many places because these strings are not all that useful.

Instead, the try-runtime APIs and machinery should either have its very own error type, or even better, use the very flexible DispatchError. All existing &'static str error can be easily converted to DispatchResult via .into().

This is slightly bad in terms of naming, as try-runtime code paths are not necessarily Dispatched, but we really want to reuse DispatchResult's ability to reference exactly which module it is coming from.

If someone works on this and realizes that it is not worthwhile, or if there is a technical issue along the way, we should remove the return type and simply standardize panics in try_state and family.

Metadata

Metadata

Assignees

Labels

J0-enhancementAn additional feature request.

Type

No type

Projects

Status

Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions