Update diener version

[joao-paulo-parity]

See paritytech/pipeline-scripts#97 (comment) for context.

Tested through paritytech/substrate#13324 (see #506 (comment)).

closes paritytech/pipeline-scripts#97

[joao-paulo-parity]

Per https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2360018 (note line 127) and https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2360019 (note line 127) from paritytech/substrate#13324, the patching seems to be happening without issues. The job is failing due to some code-related problem unrelated to diener.

[mordamax]

@joao-paulo-parity sorry by the provided links the jobs are failed
Could you please also provide an evidence of

1. regular companion PR
2. -v PATCH_polkadot=xxx or cumulus case

thanks

[joao-paulo-parity]

sorry by the provided links the jobs are failed

Yes, I'm aware. I mentioned that at the end of #506 (comment).

-v PATCH_polkadot=xxx

Why does this matter?

regular companion PR

Why would the flow with a companion PR behave differently w.r.t. diener?

[mordamax]

Yes, I'm aware. I mentioned that at the end of #506 (comment).

But it's not clear wether it was a wrong patch problem or a code, ideally that should succeed to confirm the evidence of work

-v PATCH_polkadot=xxx

Why does this matter?

The last time we updated a diener, it was working with a simple companion cases, but i didn't with a PATCH_repo. That's why I think it's important to test and make sure

Why would the flow with a companion PR behave differently w.r.t. diener?

Who knows, better know & make sure before roll-out than after

[joao-paulo-parity]

But it's not clear wether it was a wrong patch problem or a code, ideally that should succeed to confirm the evidence of work

It was explictly stated that "The job is failing due to some code-related problem unrelated to diener", but alright... I suppose it makes sense to only trust that if the job is actually passing.

The last time we updated a diener, it was working with a simple companion cases, but i didn't with a PATCH_repo. That's why I think it's important to test and make sure

There's no usage of PATCH_something in the companion scripts. Unless I'm missing something? IIRC it was the try-runtime-bot script that had something like that.

---

Anyways, although I don't think that those extra tests are useful (there should be a standard testing procedure specifically for diener changes depending on what has changed about it), I'll report back here once I have evidence of

• "No companions" case passing
• "Polkadot companion" case passing
• "Cumulus companion" case passing
• "Polkadot + Cumulus companion" case passing

[mordamax]

Thanks, looking forward for results!

There's no usage of PATCH_something in the companion scripts.

Aren't we updating it globally, so the companion & command-bot would be affected as well?
if no, which scripts does it affect?

[altaua]

Merging per https://github.com/paritytech/ci_cd/issues/773#issuecomment-1497741491