- 
                Notifications
    You must be signed in to change notification settings 
- Fork 11
feat: convert into a library #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| @ggwpez pingging for visibility. | 
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks. Is it a library crate now? I dont see a [lib] entry, i think that is needed.
| @ggwpez it is, yes. Simply create a new project with  [dependencies]
psvm = { git = "https://github.com/moliholy/psvm", branch = "feat/convert-to-library" }Then in the  
 AFAIK you don’t need a  | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thanks for the contribution. Will fix compilation warning and failing test in another PR, it is also failing in main branch, might be cause target branch (of the test) on Polkadot SDK changed. Will publish to crates.io after this.
| @patriciobcs thanks a lot! 🙏 | 
This PR essentially transforms the current repository into a mixture of binary/library. The main idea is that other projects can import
psvmas a library and utilize its public API.Tests are failing, but also in the main branch. It should be automatically fixed once they are fixed in the main branch.EDIT: On a second thought, perhaps it's just in my local machine. Let's see what the CI says.