Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Companion to Implementing MaxEncodedLen for generate_solution_type #11032 #5145

Merged
merged 9 commits into from
Mar 23, 2022
Merged

Companion to Implementing MaxEncodedLen for generate_solution_type #11032 #5145

merged 9 commits into from
Mar 23, 2022

Conversation

@georgesdib
Copy link
Contributor

@georgesdib georgesdib commented Mar 16, 2022 •
edited
Loading

Companion to paritytech/substrate#11032

Bounding generate_solution_type after changes to substrate.

@kianenigma @emostov

Fixing generate_solution_type
51b1e83 
This is needed after changes to substrate
@georgesdib georgesdib mentioned this pull request Mar 16, 2022
Merged
@kianenigma kianenigma requested a review from emostov March 22, 2022 15:37
@kianenigma kianenigma added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed. labels Mar 22, 2022
@paritytech-processbot
Copy link

Merge cancelled due to error. Error: Command 'Command { std: "git" "push" "georgesdib" "election-solution-bounded", kill_on_drop: false }' failed with status Some(1); output: To https://github.com/georgesdib/polkadot.git
! [remote rejected] election-solution-bounded -> election-solution-bounded (refusing to allow a GitHub App to create or update workflow .github/workflows/publish-draft-release.yml without workflows permission)
error: failed to push some refs to 'https://x-access-token:${SECRET}@github.com/georgesdib/polkadot.git'

@kianenigma
Copy link
Contributor

@georgesdib sorry but I think you need to give our process bot also access to your repors in the future to have this work. I will do a manual merge this time.

@kianenigma
Copy link
Contributor

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot
Copy link

Merge cancelled due to error. Error: Checks failed for 1a9bdc8

@kianenigma kianenigma merged commit 1ec8f9e into paritytech:master Mar 23, 2022
@georgesdib georgesdib deleted the election-solution-bounded branch March 23, 2022 14:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@kianenigma kianenigma kianenigma approved these changes

@emostov emostov emostov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@georgesdib @kianenigma @emostov