Remove v0 parachains runtime #1501

rphmeier · 2020-07-30T03:40:17Z

All of the functionality except for the Registrar module has been superseded by the v1 runtime modules. I removed the Registrar regardless, leaving the runtime without parachains

The Registrar Module

The registrar module previously had these functions:

Parachain and Parathread registrar
Parachain and parathread scheduling
Parathread auctions

Function 1 is now mostly provided by the Paras module. This Registrar should provide a small wrapper around the Paras for handling deposits.
Function 2 is now handled by the Scheduler module.
Function 3 should be handled by a separate a parathread_auction module.

So although the Registrar is currently being removed, those relevant pieces of logic can be recovered from the commit history when the new version is created in a follow-on PR.

We need to add para swapping (one feature of the old registrar) to the Paras module and make some small tweaks: swapping should only happen at session boundaries.

Compatibility with previous runtime

There are two main compatibility concerns: Call indices and SessionKey layout. For the former, I replaced each of the existing parachains modules with an instanced dummy module. For the latter, I will ensure that the session key layout remains the same by keeping the Parachains session key around, but where updates are simply discarded for the time being.

I also created a dummy implementation of the v0::ParachainHost runtime API. This can be removed once the BlockBuilder in polkadot-validation no longer relies on it.

rphmeier · 2020-07-30T03:54:20Z

@bkchr I'm getting a runtime error:

conflicting implementations of trait `sp_api_hidden_includes_construct_runtime::hidden_include::IsSubType<polkadot_runtime_common::dummy::Call<Runtime>>` for type `Call`:

probably because there is no typed differentiator of the dummy instances.

I'm also getting "duplicate lang item in crate std" which is puzzling, since I didn't add or change any dependency of the polkadot-runtime crate or the polkadot-runtime-common crate in this PR.

rphmeier · 2020-07-31T00:20:46Z

Icing until we can test the runtime upgrades.

runtime/polkadot/src/lib.rs

gui1117 · 2020-08-04T13:11:49Z

Registrar, Parachains, and Slots have some keys on chain (in polkadot), I guess they should be removed with some migration code
(maybe kusama also have some attestation keys)

rphmeier · 2020-08-05T08:40:17Z

I guess they should be removed with some migration code

I think we can also defer to governance on this, right? But we could also do remove_prefix

gui1117

I did start a kusama and a polkadot testnet with storage datas from kusama and polkadot (except babe, grandpa, session and staking). with the runtime from this PR (except with small session length and era length) and the client from v0.8.19, and it worked fine finalizing and new eras.

still I think we need to adress the origin changing issue otherwise looks good to me

gui1117 · 2020-08-05T17:32:05Z

runtime/polkadot/src/lib.rs

-		// Parachains stuff; slots are disabled (no auctions initially). The rest are safe as they
-		// have no public dispatchables. Disabled `Call` on all of them, but this should be
-		// uncommented once we're ready to start parachains.
-		Parachains: parachains::{Module, Call, Storage, Config, Inherent, Origin},


This changes the outer origin enum, this requires an upgrade of scheduler::Agenda storage (or a dummy variant in origin, maybe using Dummy)

(scheduler agenda holds the origin since paritytech/substrate#6387 )

Great point. We'll add the parachains origin to this PR

We did some digging, and found that the migration is not really necessary because:

The council on Polkadot and Kusama has not scheduled anything with a Parachains origin and will not, either

The Origin enum had the Parachains origin at the end, so no indices of other origins were altered

* master: Make parachain validation wasm executor functional (#1574) Use async test helper to simplify node testing (#1578) guide: validation data refactoring (#1576) Remove v0 parachains runtime (#1501) [CI] Add github token to generate-release-text (#1581) Allow using any polkadot client instead of enum Client (#1575) service/src/lib: Update authority discovery construction (#1563) Update .editorconfig to what we have in practice (#1545) Companion PR for substrate #6672 (#1560) pre-redenomination tockenSymbol change (#1561)

…n-race-condition * master: Companion PR for #6862 (#1564) implement collation generation subsystem (#1557) Add spawn_blocking to SubsystemContext (#1570) Companion PR for #6846 (#1568) overseer: add a test to ensure all subsystem receive msgs (#1590) Implementer's Guide: Flesh out more details for upward messages (#1556) Make parachain validation wasm executor functional (#1574) Use async test helper to simplify node testing (#1578) guide: validation data refactoring (#1576) Remove v0 parachains runtime (#1501) [CI] Add github token to generate-release-text (#1581) Allow using any polkadot client instead of enum Client (#1575) service/src/lib: Update authority discovery construction (#1563)

* master: overseer: fix build (#1596) Companion PR for #6862 (#1564) implement collation generation subsystem (#1557) Add spawn_blocking to SubsystemContext (#1570) Companion PR for #6846 (#1568) overseer: add a test to ensure all subsystem receive msgs (#1590) Implementer's Guide: Flesh out more details for upward messages (#1556) Make parachain validation wasm executor functional (#1574) Use async test helper to simplify node testing (#1578) guide: validation data refactoring (#1576) Remove v0 parachains runtime (#1501) [CI] Add github token to generate-release-text (#1581) Allow using any polkadot client instead of enum Client (#1575) service/src/lib: Update authority discovery construction (#1563) Update .editorconfig to what we have in practice (#1545) Companion PR for substrate #6672 (#1560) pre-redenomination tockenSymbol change (#1561)

rphmeier added 6 commits July 29, 2020 21:54

remove v0 parachains modules and switch to v1 primitives

35e4cb5

get tests compiling for runtime-common

7ec0e79

remove registrar module

25de026

Add a dummy module

0798117

remove runtime-parachains

721bd09

mostly remove old parachains code from polkadot-runtime

ea76293

rphmeier added A3-in_progress Pull request is in progress. No review needed at this stage. B2-runtimenoteworthy C1-low PR touches the given topic and has a low impact on builders. labels Jul 30, 2020

paritytech-ci added the D2-breaksapi label Jul 30, 2020

rphmeier added 2 commits July 29, 2020 23:47

remove slots::Trait implementation

bb2ddff

remove sp_std prelude import

edfe078

rphmeier added 7 commits July 30, 2020 17:52

Merge branch 'master' into rh-remove-v0-runtime

933903b

add a ZeroSizedTypeDifferentiator to dummy

96e8b8a

finish porting over polkadot runtime

5bbb31e

ZeroSizedTypeDifferentiator was actually unnecessary

03d1452

westend

c532a8f

kusama

19fca5a

Merge branch 'master' into rh-remove-v0-runtime

5c98706

rphmeier marked this pull request as ready for review July 31, 2020 00:20

rphmeier added A1-onice and removed A3-in_progress Pull request is in progress. No review needed at this stage. labels Jul 31, 2020

github-actions bot added the A0-please_review Pull request needs code review. label Jul 31, 2020

This was referenced Jul 31, 2020

Write a registrar module #1508

Closed

Parachain/thread swapping #1509

Closed

Add an origin for Parachains #1510

Closed

Create a parathread auction module for collators to bid on parathread slots #1512

Closed

rphmeier added 3 commits July 30, 2020 21:28

test-runtime (no dummy modules)

60fd854

fix warning

5fd65f6

fix chain-specs

0f69588

ordian reviewed Jul 31, 2020

View reviewed changes

runtime/polkadot/src/lib.rs Show resolved Hide resolved

rphmeier added 4 commits July 31, 2020 11:45

fix test-service

c2e1630

test-client

5ec4bb7

remove dead import

f7cec7d

remove unused needed_extrinsics parameter

96ae647

gui1117 reviewed Aug 5, 2020

View reviewed changes

rphmeier added 5 commits August 12, 2020 13:26

Merge branch 'master' into rh-remove-v0-runtime

3d0db7a

runtimes compile

ef2bc6a

remove rococo-v0

c1b1ab4

remove remaining references to Rococo

dbcabb3

bump versions

32c035d

rphmeier removed the A1-onice label Aug 12, 2020

Merge branch 'master' into rh-remove-v0-runtime

fb51b40

gui1117 approved these changes Aug 13, 2020

View reviewed changes

rphmeier merged commit ae5990c into master Aug 13, 2020

rphmeier deleted the rh-remove-v0-runtime branch August 13, 2020 13:55

rphmeier mentioned this pull request Aug 18, 2020

Remove v0 node-side parachains code #1609

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Remove v0 parachains runtime #1501

Remove v0 parachains runtime #1501

Uh oh!

rphmeier commented Jul 30, 2020 •

edited

Loading

Uh oh!

rphmeier commented Jul 30, 2020

Uh oh!

rphmeier commented Jul 31, 2020

Uh oh!

Uh oh!

gui1117 commented Aug 4, 2020

Uh oh!

rphmeier commented Aug 5, 2020

Uh oh!

gui1117 left a comment •

edited

Loading

Uh oh!

gui1117 Aug 5, 2020

Uh oh!

rphmeier Aug 5, 2020

Uh oh!

rphmeier Aug 12, 2020 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Remove v0 parachains runtime #1501

Remove v0 parachains runtime #1501

Uh oh!

Conversation

rphmeier commented Jul 30, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

The Registrar Module

Compatibility with previous runtime

Uh oh!

rphmeier commented Jul 30, 2020

Uh oh!

rphmeier commented Jul 31, 2020

Uh oh!

Uh oh!

gui1117 commented Aug 4, 2020

Uh oh!

rphmeier commented Aug 5, 2020

Uh oh!

gui1117 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gui1117 Aug 5, 2020

Choose a reason for hiding this comment

Uh oh!

rphmeier Aug 5, 2020

Choose a reason for hiding this comment

Uh oh!

rphmeier Aug 12, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

rphmeier commented Jul 30, 2020 •

edited

Loading

gui1117 left a comment •

edited

Loading

rphmeier Aug 12, 2020 •

edited

Loading