Skip to content

move json-file to common args #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2022
Merged

move json-file to common args #82

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bench-bot.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ bench_pallet_common_args=(
--execution=wasm
--wasm-execution=compiled
--heap-pages=4096
--json-file="${ARTIFACTS_DIR}/bench.json"
Copy link

@koute koute Oct 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If multiple pallets are queued won't this just keep only the result for the last pallet?

Copy link
Contributor Author

@mordamax mordamax Oct 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you mean

/cmd ...
/cmd ...

@koute or could you please provide the example of this case?
Thx

Copy link
Member

@ggwpez ggwpez Oct 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can currently only benchmark one pallet at a time with this command.
The exception is that when that pallet has multiple instances, in which case it would behave the same as it does now (but I dont know how).

Copy link
Contributor Author

@mordamax mordamax Oct 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@koute ^^

)
bench_pallet() {
local kind="$1"
Expand Down Expand Up @@ -122,7 +123,6 @@ bench_pallet() {
"${bench_pallet_common_args[@]}"
--pallet="$pallet"
--chain="${runtime}-dev"
--json-file="${ARTIFACTS_DIR}/bench.json"
--header=./file_header.txt
)

Expand Down