Replace blake2-rfc with blake2 #111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davxy
commented
Sep 15, 2022
Comment on lines
+145
to
+146
| let mut ctx = Blake2bMac::<U32>::new_with_salt_and_personal(salt, &[], &[]) | ||
| .expect("Salt length (32) is a valid key length (<= 64)"); |
There was a problem hiding this comment.
Here the naming is a bit misleading.
That is, with previous implementation the salt was used as the blake2b-rfc "key" argument while the key was used as the "data" argument.
The new_with_salt_and_personal has a dedicated parameter (the 2nd) for the salt. But to obtain the same MAC as before we have to pass salt as the 1st parameter
arkpar
approved these changes
Sep 15, 2022
cheme
approved these changes
Sep 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently Parity-DB is the only crate used by Substrate that is using
blake2-rfc.Everything else has been recently ported to RustCrypto
blake2.Please refer to this Substrate PR for some more details: paritytech/substrate#12266