Skip to content

July 2024 Documentation Update #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Jul 29, 2024
Merged

July 2024 Documentation Update #27

merged 17 commits into from
Jul 29, 2024

Conversation

@fabricwave
Copy link
Collaborator

@fabricwave fabricwave commented Jul 24, 2024

This PR intends to update stale information, improve formatting, and clarify details.

Commits

  1. Link keypair to keypair management page
  2. Match example return value to example input value
  3. Fix invalid My Little Pony smart contract address
  4. Add pre-requisites to deploy My Little Pony for Contract Proxy
  5. Add base64url dependency note for contract_proxy
  6. Clarify Cacher data structure explanation
  7. Add account creation note
  8. Move down running pchain_client section
  9. Clarify instructions on submitting transactions
  10. Increase deploy example gas limit to 500 million
  11. Add note to faucet service
  12. Fix typo error 'submiting'
  13. Fix deposit notes partially appearing outside notes block
  14. Fix invalid parameter types for calling base64url::decode
  15. Fix missing '' to 'create transaction' console command
  16. Update pchain_client version references to v0.4.4
  17. Fix dangling link to 'preparing environment' heading

Please help to check the details, and let me know if there are any questions.

Thank you.

fabricwave added 17 commits July 19, 2024 11:51
@fabricwave
Fix dangling link to 'preparing environment' heading
6c3847c
@fabricwave
Update pchain_client version references to v0.4.4
2f7ca42
@fabricwave
Fix missing '\' to 'create transaction' console command
c5b3d22
@fabricwave
Fix invalid parameter types for calling base64url::decode
62bc182
@fabricwave
Fix deposit notes partially appearing outside notes block
48fbf07
@fabricwave
Fix typo error 'submiting'
35c53ab 
Change to 'submitting'
@fabricwave
Add note to faucet service
b006f9b
@fabricwave
Increase deploy example gas limit to 500 million
f7e5d25 
Original gas limit of 100000 is not enough for deploying 'hello_contract'
@fabricwave
Clarify instructions on submitting transactions
11fe802
@fabricwave
Move down 'running pchain_client` section
8ab83f7 
Move down the 'running pchain_client' section to after 'Preparing Environment' section
@fabricwave
Add account creation note
f0e8638
@fabricwave
Clarify Cacher data structure explanation
3083df2
@fabricwave
Add base64url dependency note for contract_proxy
f9d50fb 
Required for grow_up_2() and send_tokens() functions
@fabricwave
Add pre-requisites to deploy My Little Pony for Contract Proxy
00a8d88
@fabricwave
Fix invalid My Little Pony smart contract address
8039ed6
@fabricwave
Match example return value to example input value
89e736f 
Input is "Alice", which should be returned as '5' in CallResult from `name.len() as u32`, instead of 4.
@fabricwave
Link keypair to keypair management page
f0020f9 
Managing account page contains information to create/manage a keypair.
dtlkelvin
dtlkelvin approved these changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@dtlkelvin dtlkelvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed by all stakeholders

@fabricwave fabricwave closed this Jul 26, 2024
@fabricwave fabricwave reopened this Jul 26, 2024
@dtlkelvin dtlkelvin changed the base branch from main to update_for_smartcontract_dev July 29, 2024 06:24
@dtlkelvin
Copy link
Contributor

dtlkelvin commented Jul 29, 2024

changed to a new branch from main
as an extra stage to generate a preview before merging into main

@dtlkelvin dtlkelvin self-requested a review July 29, 2024 06:29
dtlkelvin
dtlkelvin approved these changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@dtlkelvin dtlkelvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked changes are unchanged from previous review

@dtlkelvin dtlkelvin merged commit 3604b27 into parallelchain-io:update_for_smartcontract_dev Jul 29, 2024
@fabricwave fabricwave mentioned this pull request Jul 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dtlkelvin dtlkelvin dtlkelvin approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fabricwave @dtlkelvin