Add more object classes; fix tests #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems this ci.sh is missing, can you add it? Otherwise I might add some basic |
nickray
force-pushed
the
more-object-classes
branch
3 times, most recently
from
15f5cc4 to
395d8b6
Compare
Signed-off-by: Nicolas Stalder <[email protected]>
nickray
force-pushed
the
more-object-classes
branch
6 times, most recently
from
ddf0264 to
729d439
Compare
Signed-off-by: Nicolas Stalder <[email protected]>
nickray
force-pushed
the
more-object-classes
branch
from
729d439 to
790da6b
Compare
hug-dev
approved these changes
Mar 4, 2021
There was a problem hiding this comment.
First PR 🥳 Thank you!!
Looks good to me! We can export those commands in a ci.sh script if we prefer later. We did that for our other repo because we thought it was easier to maintain the script directly than the workflow commands. But until then I am ok with it!
I guess you just fixed #1 as well, great!
ionut-arm
approved these changes
Mar 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need to handle certificates in
pkcs11-uri.