[Cleaned up #37] update Papis Sci-Hub plugin #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Restore static versions (at least until repo starts tagging versions)
* Add (commented-out) [tool.setuptools_scm] section to silence
warnings once repo uses dynamic versioning
* Restore unnecessary edits
* Restore liability warning
* Restore version bounds (guessed for bs4)
* Restore classifiers, keywords, authors
* Relax python version bounds
* Explicitly use standard GPL3 text
* Make pylint-clean for python >=3.6
* Convert `| None` to uses of `Optional[]` to silence warnings on
Pythons older than 3.10
* Use more specific exceptions
* Clean up early-exit logic, drop useless exception catches
* Standardize names
* Misc improvements
* Fix `download_bibtex()` type
* Add sci-hub mirrors
|
Would've squashed the original commits to prevent some of the noise, but wanted to preserve attribution. |
|
Any updates on this? It should be a clean merge. |
|
@alejandrogallo Mind merging this? At the moment, the AUR package is building off my branch, which is not ideal. |
The tests in the latest papis commits exposed a missing branch in these conditionals, leading to an UnboundLocalError.
|
Missed a bug in And sorry for the noise here -- tried renaming the branch, but turns out Github doesn't like that. For another time. |
|
BTW, please add versioning tags when merging this -- I'm currently force-tagging the base commit in my packaging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features:
ImportertoDownloaderscihub, instead plugin scrapes the actual webpageusing
bs4pyproject.tomlinstead ofsetup.pyREADME.rstbyREADME.mdDiff off original:
warnings once repo uses dynamic versioning
| Noneto uses ofOptional[]to silence warnings onPythons older than 3.10
download_bibtex()typeCloses: #37