fixing scoverage sourcePath to be relative in OSS #8132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuhood
approved these changes
Aug 2, 2019
|
@wisechengyi : The effect of merging this directly to 1.25.x is that it is only in 1.25.x, and not also in master (or 1.26.x, for that matter). Please ensure that we always merge to master first, and then cherry-pick to branches. I'll cherry pick this back to master. |
|
Ok, I see... I guess we had some other PR to do this that landed in master? #9245 maybe? Sorry. Bit of a mess. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherrypick of 3bc6af6 onto 1.25.x