ENH: Add option in read_csv to infer compression type from filename #9770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it would even be fine even to change the default here. We are not that strict about backwards compatibility in pandas -- any users who relied on the previous behavior were basically relying on a bug. |
|
I agree with @shoyer here, let's just have it infer these filename endings as compression (move the release note to the API section). |
evanpw
force-pushed
the
infer_compression
branch
from
fe09884 to
48fd726
Compare
|
I've totally borked this branch with an accidental force push. I'll fix it tonight. |
evanpw
force-pushed
the
infer_compression
branch
from
fe09884 to
7fe1c69
Compare
|
Should be fixed. |
| compression : {'gzip', 'bz2', 'infer', None}, default 'infer' | ||
| For on-the-fly decompression of on-disk data. If 'infer', then use gzip or | ||
| bz2 if filepath_or_buffer is a string ending in '.gz' or '.bz2', | ||
| respectively, and no decompression otherwise. |
There was a problem hiding this comment.
Can you add here what None does?
|
couple of minor comments, pls rebase, and ping when green |
evanpw
force-pushed
the
infer_compression
branch
from
7fe1c69 to
6cb41c6
Compare
|
Docs are fixed, rebased/squashed, and tests are green. |
|
Looks great to me! |
jreback
added a commit
that referenced
this pull request
Apr 18, 2015
ENH: Add option in read_csv to infer compression type from filename
|
@evanpw thanks! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ideally, I would love for this to be the default, but that wouldn't be backwards-compatible in the case where the filename ends in '.gz' or '.bz2' and you want to treat it as uncompressed. That seems like it would be very rare, though.