TST/CLN: Refactor io.data.options class to improve testing #7665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed most references to month and year (passing expiry date around instead). Also protected with RemoteDataError checking for the expiry month links.
Contributor
|
https://travis-ci.org/pydata/pandas/jobs/29115841 looks like need to trap that failure as well thanks! |
Contributor
Author
|
There's no way to tell what the variables where at the time of the error on Travis CI is there? I don't want to trap too wide of an error - I'm guessing it failed there because it wasn't able to retrieve the underlying price. |
Contributor
|
since mkt is closed, you might be able to reprod. You can 'trap' the error, then just use print statements (it will print to the log) |
Removed most references to month and year (passing expiry date around instead). Also protected with RemoteDataError checking for the expiry month links.
Contributor
Author
|
I recreated it. A missing underlying price. Checked to make sure there is an underlying before reducing the dataframe. |
jreback
added a commit
that referenced
this pull request
Jul 7, 2014
TST/CLN: Refactor io.data.options class to improve testing
Contributor
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed most references to month and year (passing expiry date around instead).
Also protected with RemoteDataError checking for the expiry month links.
Fixes #7648