API: update SQL functional api (GH6300) #6867
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OK, I think this is fine now. I only changed the toplevel api (so Somebody care to do a quick review? @hayd @jreback @danielballan @mangecoeur |
|
Other than those minors docstring suggestions, looks great to me. |
|
Looks good (sorry, thought I commented earlier!) |
|
Thanks for the comments! Adapted the summary lines of the docstrings a bit. |
jorisvandenbossche
added a commit
that referenced
this pull request
Apr 18, 2014
API: update SQL functional api (GH6300)
17 tasks
This was referenced Apr 21, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First draft for the functional api part of #6300.