ENH: consistent exception messages for arithmetic #62455
+234
−107
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #62423, does not close.
This does not take a stand on whether to support list/tuple in the EA methods. An EA that currently supports it will continue to, likewise for arrays that don't support it.
Not taking that stand limits the amount of de-duplication/centralization we can do. Instead of all the exceptions being raised from unpack_zerodim_and_defer, helpers
ops.get_op_exception_message
andops.get_shape_exception_message
should at least help us get to consistent messages.I did a pass to try to use these new helpers where relevant, but definitely didn't get them all. I also didn't implement
_supports_(scalar|array)_op
yet.Before I go through the tests to update the exception messages, I'd like to get any bikeshedding out of the way about exactly what those messages should say.