BUG: Fix assert_series_equal for categoricals with nulls and check_category_order=False (#62008) #62011
+22
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @mroeschke I'd really appreciate it if you could take a look and provide feedback . Thanks! |
|
Hi @jorisvandenbossche, |
pandas-dev#61942) and add whatsnew note
pandas-dev#61942) and add whatsnew note
pandas-dev#61942) and add whatsnew note
pandas-dev#61942) and add whatsnew note
pandas-dev#61942) and add whatsnew note
pandas-dev#61942) and add whatsnew note
pandas-dev#61942) and add whatsnew note
pandas-dev#61942) and add whatsnew note
…tegory_order=False (pandas-dev#62008)
Aniketsy
force-pushed
the
fix-assert-categorical-equal-nans
branch
from
24ac0d7 to
1b70b3a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where
pd.testing.assert_series_equalfails when comparing Series with categorical values containing NaNs when usingcheck_category_order=False.Problem
When using
left.categories.take(left.codes)for comparing category values, null codes (-1) were not handled correctly, causing incorrect comparisons.Please let me know if my approach or fix needs any improvements . I’m open to feedback and happy to make changes based on suggestions.