More @network fixes #6174
Merged
More @network fixes #6174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
merged commit 
Contributor
There was a problem hiding this comment.
nice way to hack around this :)
Author
There was a problem hiding this comment.
desperate you mean. I can't believe how screwed up this corner of python is,
you literraly have to do all this to catch these network errors. Timeouts can bubble
up in at least 5 different ways, diff exceptions, with errno or with out. nightmare.
The code for @network, and the kwarg lists were really nice to see after
wallowing in the muck of indexing.py. kudos.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More fixes to @network to handle the incredibly unreliable yahoo servers.
This should do it.
The mind boggles that a billion-dollar company can have a QoS this bad.
N.B. the default socket timeout setting.
It's not required for this because I believe travis has some firewall rules that
timeout net connections, but it's nicer when running locally where connections
can hang for much longer. 15 seconds is very generous so I hope it's not disruptive.
cc @jreback, @jtratner