Skip to content

TST: Update numpy version check for test_pandas_dtype_numpy_warning #60929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 14, 2025
Merged

TST: Update numpy version check for test_pandas_dtype_numpy_warning #60929

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fac82d6
TST: Update numpy version check for test_pandas_dtype_numpy_warning
mroeschke Feb 13, 2025
419a630
less than the dev version
mroeschke Feb 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pandas/core/dtypes/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1836,7 +1836,7 @@ def pandas_dtype(dtype) -> DtypeObj:
# raise a consistent TypeError if failed
try:
with warnings.catch_warnings():
# TODO: warnings.catch_warnings can be removed when numpy>2.2.2
# TODO: warnings.catch_warnings can be removed when numpy>2.3.0
# is the minimum version
# GH#51523 - Series.astype(np.integer) doesn't show
# numpy deprecation warning of np.integer
Expand Down
2 changes: 1 addition & 1 deletion pandas/tests/dtypes/test_common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -789,7 +789,7 @@ def test_validate_allhashable():

def test_pandas_dtype_numpy_warning():
# GH#51523
if Version(np.__version__) <= Version("2.2.2"):
if Version(np.__version__) < Version("2.3.0.dev0"):
ctx = tm.assert_produces_warning(
DeprecationWarning,
check_stacklevel=False,
Expand Down