TST: Interchange implementation for timestamp[ns][pyarrow] #57026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
suggested changes
Jan 26, 2024
Comment on lines
303
to
304
| result["col0"] = result["col0"].astype("timestamp[ns][pyarrow]") | ||
| tm.assert_frame_equal(df, result) |
Member
There was a problem hiding this comment.
can we check the result explicitly please?
like
result = pd.api.interchange.from_dataframe(dfi)['col0'].item()
expected = pd.Timestamp(...)
assert result == expected
, fill in Timestamp
MarcoGorelli
suggested changes
Jan 29, 2024
Member
MarcoGorelli
left a comment
MarcoGorelli
left a comment
There was a problem hiding this comment.
this is failing CI
FAILED pandas/tests/interchange/test_impl.py::test_timestamp_ns_pyarrow - NameError: name 'pa' is not defined
Contributor
Author
|
Hi, thanks for pointing out, I added the necessary |
MarcoGorelli
approved these changes
Jan 29, 2024
Member
MarcoGorelli
left a comment
MarcoGorelli
left a comment
There was a problem hiding this comment.
thanks @aidoskanapyanov (CI failure is unrelated)
pmhatre1
pushed a commit
to pmhatre1/pandas-pmhatre1
that referenced
this pull request
May 7, 2024
…v#57026) * TST: Interchange implementation for timestamp[ns][pyarrow] * Check timestamp explicitly * Use pytest.importorskip --------- Co-authored-by: Marco Edward Gorelli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
timestamp[ns][pyarrow]type correctly #56712doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.