Fix CI not raised when there's an error #56897
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datapythonista
added
CI
datapythonista
approved these changes
Jan 16, 2024
Member
datapythonista
left a comment
datapythonista
left a comment
There was a problem hiding this comment.
Nice catch @tqa236
It would be great if you can fix in this same PR the two errors we currently have that are ignored by the CI. So we can merge this PR without making the CI of the main branch crash. Do you want to have a look? Otherwise I'll check myself, so we can continue merging the related PRs
Contributor
Author
|
hello @datapythonista, I fixed them here: #56855 |
Member
|
Amazing, thanks for that PR. This one is empty now since everything was fixed there. Closing, thanks a lot for finding and fixing those errors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.