CoW warning mode: clean-up some TODOs #56080
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorisvandenbossche
added
Warnings
| # TODO(CoW-warn) should warn | ||
| if using_copy_on_write or warn_copy_on_write: | ||
| subset["a"] = arr |
There was a problem hiding this comment.
We are replacing a full column (so never updating the original), so while this gives a SettingWithCopyWarning right now, we don't have to warn anything here for CoW
Comment on lines
-515
to
514
| # TODO(CoW-warn) should warn | ||
| if using_copy_on_write or warn_copy_on_write: | ||
| subset[["a", "c"]] = 0 |
There was a problem hiding this comment.
Similarly here, replacing full columns, so don't have to warn
phofl
approved these changes
Nov 20, 2023
phofl
pushed a commit
to phofl/pandas
that referenced
this pull request
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #56019
Going through some of the TODOs, removing a few that have been tackled in the meantime and adding some more detail to others.
Also went through every test in
pandas/tests/copy_view/test_indexing.pyand ensured that each test is correctly asserting a warning (or not), or has a TODO(CoW-warn) if that's not yet the case.