Skip to content

TYP: plotting #55829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 6, 2023
Merged

TYP: plotting #55829

merged 3 commits into from
Nov 6, 2023

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@mroeschke mroeschke added Visualization plotting Typing type annotations, mypy/pyright type checking labels Nov 4, 2023
WillAyd
WillAyd approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mroeschke mroeschke added this to the 2.2 milestone Nov 6, 2023
@mroeschke mroeschke merged commit 6d662b8 into pandas-dev:main Nov 6, 2023
@mroeschke
Copy link
Member

Thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the typ-plotting-3 branch November 6, 2023 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WillAyd WillAyd WillAyd approved these changes

@mroeschke mroeschke mroeschke approved these changes

Assignees

No one assigned

Labels

Typing type annotations, mypy/pyright type checking Visualization plotting

Projects

None yet

Milestone

2.2

Development

Successfully merging this pull request may close these issues.

3 participants

@jbrockmendel @mroeschke @WillAyd