Skip to content

Conversation

@barseghyanartur
Copy link
Contributor

@barseghyanartur barseghyanartur commented Sep 25, 2023

closes #55290

Simply said, none of this would work (dependencies from output-formatting would not be installed):

pip install pandas[output-formatting]
pip install pandas[output_formatting]
pip install pandas[output-formatting,xml]

When being distributed, underscores are replaces with dashes. So, in the packaged PKG-INFO file you won't find spots of output_formatting, but only output-formatting:

Requires-Dist: lxml>=4.8.0; extra == "xml"
Requires-Dist: jinja2>=3.1.2; extra == "output-formatting"
Requires-Dist: tabulate>=0.8.10; extra == "output-formatting"

But on the same time, this:

Provides-Extra: output_formatting

This fix addresses that.

@mroeschke
Copy link
Member

Thanks could you add a whatsnew note in 2.1.2.rst?

@mroeschke mroeschke added the Build Library building on various platforms label Sep 25, 2023
@barseghyanartur
Copy link
Contributor Author

@mroeschke:

Done.

@mroeschke
Copy link
Member

Could you also change the references in doc/source/getting_started/install.rst and .github/workflows/package-checks.yml?

@barseghyanartur
Copy link
Contributor Author

@mroeschke:

Done.

@mroeschke mroeschke added this to the 2.1.2 milestone Sep 26, 2023
@mroeschke mroeschke merged commit 89bd569 into pandas-dev:main Sep 26, 2023
@mroeschke
Copy link
Member

Thanks @barseghyanartur

meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Sep 26, 2023
mroeschke pushed a commit that referenced this pull request Sep 26, 2023
…output_formatting` with `output-formatting`) (#55291)

Backport PR #55275: Update pyproject.toml - replace `output_formatting` with `output-formatting`

Co-authored-by: Artur Barseghyan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Build Library building on various platforms

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUILD: pandas[output_formatting] doesn't install optional dependencies

2 participants