Skip to content

Fix #54391: Use memcpy() for unaligned loads #54407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 4, 2023
Merged

Fix #54391: Use memcpy() for unaligned loads #54407

merged 1 commit into from
Aug 4, 2023

Conversation

SoapGentoo
Copy link
Contributor

@SoapGentoo SoapGentoo commented Aug 4, 2023 •
edited
Loading

@SoapGentoo SoapGentoo requested a review from WillAyd as a code owner August 4, 2023 13:29
@SoapGentoo
Copy link
Contributor Author

@WillAyd I've coalesced all the changes together now

@SoapGentoo SoapGentoo mentioned this pull request Aug 4, 2023
Closed
5 tasks
WillAyd
WillAyd reviewed Aug 4, 2023
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work - great change overall

@mroeschke mroeschke added ARM aarch64 architecture Internals Related to non-user accessible pandas implementation labels Aug 4, 2023
@mroeschke mroeschke added this to the 2.1 milestone Aug 4, 2023
WillAyd
WillAyd approved these changes Aug 4, 2023
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work

@mroeschke mroeschke merged commit 5be4339 into pandas-dev:main Aug 4, 2023
@mroeschke
Copy link
Member

Thanks @SoapGentoo

@SoapGentoo SoapGentoo deleted the bug-54391-unaligned-loads branch August 5, 2023 11:35
mroeschke pushed a commit to mroeschke/pandas that referenced this pull request Aug 18, 2023
@SoapGentoo @mroeschke
Fix pandas-dev#54391: Use memcpy() for unaligned loads (pandas-dev#54407
427bb68 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd WillAyd approved these changes

@mroeschke mroeschke mroeschke approved these changes

+1 more reviewer

@thesamesam thesamesam thesamesam approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
ARM aarch64 architecture Internals Related to non-user accessible pandas implementation
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.

BUG: SIGBUS in test_float_byteswap test on arm
4 participants
@SoapGentoo @mroeschke @WillAyd @thesamesam