Skip to content

DEPS: drop np 1.20 #52661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Apr 20, 2023
Merged

DEPS: drop np 1.20 #52661

merged 12 commits into from
Apr 20, 2023

Conversation

@fangchenli
Copy link
Member

@fangchenli fangchenli commented Apr 13, 2023

No description provided.

@fangchenli fangchenli added the Dependencies Required and optional dependencies label Apr 13, 2023
jbrockmendel
jbrockmendel reviewed Apr 13, 2023
View reviewed changes
jbrockmendel
jbrockmendel reviewed Apr 13, 2023
View reviewed changes
jbrockmendel
jbrockmendel reviewed Apr 13, 2023
View reviewed changes
@fangchenli
Copy link
Member Author

fangchenli commented Apr 14, 2023

The errors seem not related. #45651

@fangchenli fangchenli marked this pull request as ready for review April 19, 2023 05:05
@mroeschke
Copy link
Member

mroeschke commented Apr 19, 2023

  1. Could you add this to the table of updated versions in the whatsnew note for 2.1?
  2. Could you change this version in pyproject.toml and the sdist GHA workflow?
  3. It looks like there's a try/except in pandas/tests/extension/base/dtype.py::BaseDtypeTests:test_check_dtype that can be removed now based on a comment regarding numpy 1.20

@mroeschke
Copy link
Member

mroeschke commented Apr 19, 2023 

=================================== FAILURES ===================================
_______________ TestBaseDtype.test_check_dtype[decimal128(7, 3)] _______________
[gw0] linux -- Python 3.8.0 /home/runner/micromamba/envs/test/bin/python3.8
[XPASS(strict)] decimal string repr affects numpy comparison

@mroeschke mroeschke added this to the 2.1 milestone Apr 20, 2023
@mroeschke mroeschke merged commit 233152d into pandas-dev:main Apr 20, 2023
@mroeschke
Copy link
Member

mroeschke commented Apr 20, 2023

Thanks @fangchenli

@fangchenli fangchenli deleted the drop-np-120 branch May 25, 2023 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jbrockmendel jbrockmendel jbrockmendel left review comments

@mroeschke mroeschke mroeschke approved these changes

Assignees

No one assigned

Labels

Dependencies Required and optional dependencies

Projects

None yet

Milestone

2.1

Development

Successfully merging this pull request may close these issues.

3 participants

@fangchenli @mroeschke @jbrockmendel