Skip to content

Conversation

@jankatins
Copy link
Contributor

The doc generation failed under windows due to problems with sphinx
and encoded umlauts in code (see links in
#5142).

The workaround is to replace the offending text with one which does not fail
(but which makes the example a bit pointless), build the docs and restore the
old text.

Closes: #5142

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this should be in here. Normal users who read the docs on the website shoudn't be bothered with that I think.

@jtratner
Copy link
Contributor

2 things:

  1. Can you add a comment to the doc fixing code that says 'Sphinx fails on embedded unicode on Windows'.
  2. Can you make the comment show up only on Windows? Eg put it with the replacement? I think it would be cleaner.

@jankatins
Copy link
Contributor Author

@jtratner like this?

The doc generation failed under windows due to problems with sphinx
and encoded umlauts in code (see links in
#5142).

The workaround is to replace the offending text with one which does not fail
(but which makes the example a bit pointless), build the docs and restore the
old text.
On windows, these generated files are often left over due to
"file in use" errors. Remove them after the doc build has finished.
@jankatins
Copy link
Contributor Author

Please remove this PR, I think I found the real cause of the failing doc builds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

doc generation fails on windows

3 participants