Skip to content

Conversation

MarcoGorelli
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@MarcoGorelli
Copy link
Member Author

MarcoGorelli commented Dec 31, 2022

ok, even without pandas-dev-flaker, flake8 is still the slowest hook

gonna try to push forwards with removing it in favour of ruff then

$ python hook-timings.py
pandas-errors-documented          0.04
title-capitalization              0.05
validate-min-versions-in-sync     0.06
pip-to-conda                      0.07
end-of-file-fixer                 0.07
pg8000-not-installed-CI           0.09
seed-check-asv                    0.10
invalid-ea-testing                0.10
future-annotations                0.10
sync-flake8-versions              0.11
no-bool-in-core-generic           0.11
cython-casting                    0.13
no-return-exception               0.16
incorrect-backticks               0.18
rst-backticks                     0.22
np-testing-array-equal            0.22
trailing-whitespace               0.27
double-quote-cython-strings       0.45
rst-directive-colons              0.52
flake8-pyi                        0.66
use-pd_array-in-core              0.68
validate-errors-locations         0.70
rst-inline-touching-normal        0.71
unwanted-patterns                 0.88
use-io-common-urlopen             1.10
cpplint                           1.43
codespell                         1.44
flake8-rst                        2.84
check-test-naming                 3.16
debug-statements                  4.27
absolufy-imports                  4.29
isort                             5.41
cython-lint                       5.55
vulture                           7.86
sphinx-lint                      11.85
pyupgrade                        17.31
black                            43.71
flake8                           57.68
dtype: float64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant