STYLE enable B005 check in flake8-bugbear #49707
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twoertwein
reviewed
Nov 16, 2022
twoertwein
approved these changes
Nov 17, 2022
Member
Author
|
Thanks @twoertwein for reviewing! |
MarcoGorelli
added a commit
to MarcoGorelli/pandas
that referenced
this pull request
Nov 18, 2022
* fixup b005 errors * use sys.version_info check * replace redefined func * fixup * use version_info check in _str_methods too * move import * put unnecessary else statement Co-authored-by: MarcoGorelli <>
mliu08
pushed a commit
to mliu08/pandas
that referenced
this pull request
Nov 27, 2022
* fixup b005 errors * use sys.version_info check * replace redefined func * fixup * use version_info check in _str_methods too * move import * put unnecessary else statement Co-authored-by: MarcoGorelli <>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #40570 (comment)
I agree,
strip/rstrip/lstripare common sources of confusion https://docs.python.org/3/library/stdtypes.html#str.lstrip , e.g.