API: retain non-nano dtype in DatetimeArray constructor #49058
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Datetime
mroeschke
reviewed
Oct 14, 2022
| data = astype_overflowsafe(data, dtype=DT64NS_DTYPE) | ||
| new_dtype = data.dtype | ||
| data_unit = get_unit_from_dtype(new_dtype) | ||
| if not is_supported_unit(data_unit): |
There was a problem hiding this comment.
Is it generally not possible to get a dt64tz type with an unsupported unit?
mroeschke
approved these changes
Oct 18, 2022
|
Thanks @jbrockmendel |
noatamir
pushed a commit
to noatamir/pandas
that referenced
this pull request
Nov 9, 2022
…9058) * API: retain non-nano dtype in DatetimeArray constructor * update test * un-xfail * un-xfail * un-xfail
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Has one test that will fail until #49050.