BUG in read_pickle

[Kinza-Raza]

• closes BUG in read_pickle #47895
• passes all checks
• Fixed note in the latest pandas/io/pickle.py

[MarcoGorelli]

Thanks, wording looks good!

I was surprised that flake8 wasn't throwing an error because of the long line, then I noticed noqa: E501 on L185

While we're here, could you please rewrite L167 so it spans multiple lines, like

    >>> original_df = pd.DataFrame(
    ...     {{"foo": range(5), "bar": range(5, 10)}}
    ...    )  # doctest: +SKIP

and then split the line you added into 2 lines, and also remove the noqa: E501 on line 185?

[pep8speaks]

Hello @Kinza-Raza! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2022-08-09 00:07:23 UTC

[Kinza-Raza]

@MarcoGorelli I was trying to build the documentation as explained here but got some import errors (modules not found) even though I built the dev environment with docker.

It says in make.py

To build the docs you must have all optional dependencies for pandas
installed. See the installation instructions for a list of these.

Could you redirect me to the installation instructions for future reference so I can view the changes I'm making? Many thanks!

[MarcoGorelli]

Thanks @Kinza-Raza

[MarcoGorelli]

Could you redirect me to the installation instructions for future reference so I can view the changes I'm making? Many thanks!

The instructions should all be in https://pandas.pydata.org/docs/development/contributing.html - if anything's not clear / doesn't work, please do feel free to ask for help