ENH: Move database error to error/__init__.py per GH27656 #47674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dataxerik
commented
Jul 11, 2022
dataxerik
commented
- xref API: many custom errors / warnings are not exposed in pandas.errors #27656. this GitHub issue is being done in multiple parts
- Tests added and passed if fixing a bug or adding a new feature
- All code checks passed.
mroeschke
reviewed
Jul 11, 2022
pandas/errors/__init__.py
Outdated
| Examples | ||
| -------- | ||
| >>> import pandas.io.sql as sql |
There was a problem hiding this comment.
Can just call pd.read_sql below
There was a problem hiding this comment.
I don't think it's necessary to demo sql.execute since it's not public
There was a problem hiding this comment.
Updated. Maybe an obvious question, how do you know if something is public or not?
There was a problem hiding this comment.
Good question (and definitely not obvious). Anything in the pandas namespace import pandas as pd or pandas/api is public. Users can access other namespaces but they are not "public" e.g. pandas.core
There was a problem hiding this comment.
Gotcha, thank you for the information!
mroeschke
approved these changes
Jul 14, 2022
|
Thanks @dataxerik |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.