Skip to content

CI: Run all code checks even if one fails #47482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2022
Merged

CI: Run all code checks even if one fails #47482

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions .github/workflows/code-checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,37 +65,39 @@ jobs:
id: build
uses: ./.github/actions/build_pandas

# The following checks are independent of each other and should still be run if one fails
- name: Check for no warnings when building single-page docs
run: ci/code_checks.sh single-docs
if: ${{ steps.build.outcome == 'success' }}
if: ${{ steps.build.outcome == 'success' && always() }}

- name: Run checks on imported code
run: ci/code_checks.sh code
if: ${{ steps.build.outcome == 'success' }}
if: ${{ steps.build.outcome == 'success' && always() }}

- name: Run doctests
run: ci/code_checks.sh doctests
if: ${{ steps.build.outcome == 'success' }}
if: ${{ steps.build.outcome == 'success' && always() }}

- name: Run docstring validation
run: ci/code_checks.sh docstrings
if: ${{ steps.build.outcome == 'success' }}
if: ${{ steps.build.outcome == 'success' && always() }}

- name: Use existing environment for type checking
run: |
echo $PATH >> $GITHUB_PATH
echo "PYTHONHOME=$PYTHONHOME" >> $GITHUB_ENV
echo "PYTHONPATH=$PYTHONPATH" >> $GITHUB_ENV
if: ${{ steps.build.outcome == 'success' && always() }}

- name: Typing
uses: pre-commit/[email protected]
with:
extra_args: --hook-stage manual --all-files
if: ${{ steps.build.outcome == 'success' }}
if: ${{ steps.build.outcome == 'success' && always() }}

- name: Run docstring validation script tests
run: pytest scripts
if: ${{ steps.build.outcome == 'success' }}
if: ${{ steps.build.outcome == 'success' && always() }}

asv-benchmarks:
name: ASV Benchmarks
Expand Down