Skip to content

Fix signature of initObjToJSON #47466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 23, 2022
Merged

Fix signature of initObjToJSON #47466

merged 1 commit into from
Jun 23, 2022

Conversation

@hoodmane
Copy link
Contributor

@hoodmane hoodmane commented Jun 22, 2022 •
edited
Loading

This patch is required to make Pandas compile with -Wl,--fatal-warnings. It is also needed to prevent an "indirect call signature mismatch" error when using pandas in wasm. This is the only patch Pyodide currently applies to Pandas.

@lithomas1 lithomas1 requested a review from WillAyd June 23, 2022 13:50
@WillAyd
Copy link
Member

WillAyd commented Jun 23, 2022

Strange. Does this line not need to change too?

pandas/pandas/_libs/src/ujson/python/ujson.c

Line 46 in 45f094d

void initObjToJSON(void);

@WillAyd
Copy link
Member

WillAyd commented Jun 23, 2022

Sorry misread that. This lgtm

@hoodmane
Copy link
Contributor Author

hoodmane commented Jun 23, 2022

For the record the error we get without this is:

wasm-ld: error: function signature mismatch: initObjToJSON
>>> defined as () -> void in build/temp.emscripten_3_1_13_wasm32-cpython-310/pandas/_libs/src/ujson/python/ujson.o
>>> defined as () -> i32 in build/temp.emscripten_3_1_13_wasm32-cpython-310/pandas/_libs/src/ujson/python/objToJSON.o

@mroeschke mroeschke added this to the 1.5 milestone Jun 23, 2022
@mroeschke mroeschke added the IO JSON read_json, to_json, json_normalize label Jun 23, 2022
@mroeschke mroeschke merged commit d3bb89d into pandas-dev:main Jun 23, 2022
@mroeschke
Copy link
Member

mroeschke commented Jun 23, 2022

Thanks @hoodmane

yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
@hoodmane @yehoshuadimarsky
Fix signature of initObjToJSON (pandas-dev#47466)
673b7b9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WillAyd WillAyd WillAyd approved these changes

@mroeschke mroeschke mroeschke approved these changes

Assignees

No one assigned

Labels

IO JSON read_json, to_json, json_normalize

Projects

None yet

Milestone

1.5

Development

Successfully merging this pull request may close these issues.

3 participants

@hoodmane @WillAyd @mroeschke