Skip to content

Backport PR #47150 on branch 1.4.x (DEPS: Bump Cython) #47152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 28, 2022
Merged

Backport PR #47150 on branch 1.4.x (DEPS: Bump Cython) #47152

merged 2 commits into from
May 28, 2022

Conversation

@meeseeksmachine
Copy link
Contributor

@meeseeksmachine meeseeksmachine commented May 27, 2022

Backport PR #47150: DEPS: Bump Cython

@lumberbot-app lumberbot-app bot added this to the 1.4.3 milestone May 27, 2022
@lumberbot-app lumberbot-app bot added CI Continuous Integration Dependencies Required and optional dependencies labels May 27, 2022
@simonjayhawkins
Copy link
Member

simonjayhawkins commented May 28, 2022

Numpy Dev failing with RuntimeError: Cannot cythonize with old Cython version (0.29.24 installed, needs 0.29.30). we perhaps are missing a backport somewhere?

@simonjayhawkins
Copy link
Member

simonjayhawkins commented May 28, 2022

Numpy Dev failing with RuntimeError: Cannot cythonize with old Cython version (0.29.24 installed, needs 0.29.30). we perhaps are missing a backport somewhere?

#46029 was not backported.

can either backport that one or change the cython version in ci/deps/actions-310-numpydev.yaml here?

@simonjayhawkins
Copy link
Member

simonjayhawkins commented May 28, 2022

can either backport that one or change the cython version in ci/deps/actions-310-numpydev.yaml here?

looking through the code changes in that PR, probably safer just to change to 0.29.30 in actions-310-numpydev.yaml here and if there is another patch release in 1.4.x we could decide to add Cython 3 support later if deemed necessary. (or just wait for 1.5)

@simonjayhawkins
Copy link
Member

simonjayhawkins commented May 28, 2022

Numpy Dev green. other jobs passed on last run. so merging.

@simonjayhawkins simonjayhawkins merged commit 48a9a95 into pandas-dev:1.4.x May 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CI Continuous Integration Dependencies Required and optional dependencies

Projects

None yet

Milestone

1.4.3

Development

Successfully merging this pull request may close these issues.

3 participants

@meeseeksmachine @simonjayhawkins @lithomas1