-
-
Notifications
You must be signed in to change notification settings - Fork 19.3k
BUG: Fix __instancecheck__ and __subclasscheck__ of metaclass in pandas.core.dtypes.generic #46719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: Fix __instancecheck__ and __subclasscheck__ of metaclass in pandas.core.dtypes.generic #46719
Conversation
rhshadrach
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Looks really good, but I suppose a test should also be added for apply as well.
|
Alright done! |
jreback
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm over to you @rhshadrach
rhshadrach
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
Thanks @leonarduschen! |
…as.core.dtypes.generic (pandas-dev#46719)
TypeError: copy() missing 1 required positional argument: 'self'#46684 (Replace xxxx with the Github issue number)doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.#46684 is caused by wrong
__instancecheck__implementation, but__subclasscheck__implementation is also wrong. I fixed both.