BLD: Upload sdist artifact from CI #46277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now it is possible to inspect the sdist that is built, to see what was included and for debugging. Inspired by needing to see what was acutally included in the sdist at pandas-dev#46271
Got this error before: Error: Artifact name is not valid: refs/pull/46277/merge-3.8-sdist.gz. Contains the following character: Forward slash / This is more precise anyways.
|
After this PR, you can download the sdist build:
|
4 tasks
|
The test failures above are unrelated |
lithomas1
suggested changes
Mar 9, 2022
lithomas1
approved these changes
Mar 10, 2022
mroeschke
approved these changes
Mar 11, 2022
|
Thanks @NickCrews |
simonjayhawkins
pushed a commit
to simonjayhawkins/pandas
that referenced
this pull request
Mar 30, 2022
* BLD: Upload sdist artifact from CI Now it is possible to inspect the sdist that is built, to see what was included and for debugging. Inspired by needing to see what was acutally included in the sdist at pandas-dev#46271 * BLD: fix artifact name Got this error before: Error: Artifact name is not valid: refs/pull/46277/merge-3.8-sdist.gz. Contains the following character: Forward slash / This is more precise anyways. * BLD: Drop SHA from sdist artifact name Per pandas-dev#46277 (comment)
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
* BLD: Upload sdist artifact from CI Now it is possible to inspect the sdist that is built, to see what was included and for debugging. Inspired by needing to see what was acutally included in the sdist at pandas-dev#46271 * BLD: fix artifact name Got this error before: Error: Artifact name is not valid: refs/pull/46277/merge-3.8-sdist.gz. Contains the following character: Forward slash / This is more precise anyways. * BLD: Drop SHA from sdist artifact name Per pandas-dev#46277 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now it is possible to inspect the sdist that is built, to
see what was included and
for debugging.
Inspired by needing to see what was acutally included in the sdist at
#46271
options.package_datafrom setup.cfg #46271 (Replace xxxx with the Github issue number)doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.@fangchenli again. Thank you!