Skip to content

CI: pin markupsafe to avoid import error #46054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 18, 2022
Merged

CI: pin markupsafe to avoid import error #46054

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7132618
CI: pin markupsafe to avoid import error
phofl Feb 18, 2022
8e0f2e5
Add comment
phofl Feb 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ci/deps/actions-38-minimum_versions.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ dependencies:
- numpy=1.18.5
- pytz=2020.1

# optional dependencies
# optional dependencies, markupsafe for jinja2
- beautifulsoup4=4.8.2
- blosc=1.20.1
- bottleneck=1.3.1
Expand All @@ -29,6 +29,7 @@ dependencies:
- gcsfs=0.6.0
- jinja2=2.11
- lxml=4.5.0
- markupsafe=2.0.1
Copy link
Member

@mroeschke mroeschke Feb 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a note that this is a Jinja dependency not necessarily a pandas one and why it was pinned?

Copy link
Member Author

@phofl phofl Feb 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, we can not really add comments inline, because the version sync script can not deal with them. Added it in the optional dependencies header line

Copy link
Member

@mroeschke mroeschke Feb 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

- matplotlib=3.3.2
- numba=0.50.1
- numexpr=2.7.1
Expand Down
1 change: 1 addition & 0 deletions pandas/compat/_optional.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
"gcsfs": "0.6.0",
"jinja2": "2.11",
"lxml.etree": "4.5.0",
"markupsafe": "2.0.1",
"matplotlib": "3.3.2",
"numba": "0.50.1",
"numexpr": "2.7.1",
Expand Down