BUG: Fix implementation of temp_setattr #45954
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Feb 15, 2022
pandas/tests/test_common.py
Outdated
| # GH#45954 | ||
| ser = Series(dtype=object) | ||
| ser.name = "first" | ||
| try: |
Member
There was a problem hiding this comment.
Maybe a bit more robust to validate the error raised:
if with_exception:
maybe_raises = pytest.raises(ValueError, match="Exception raised")
else:
maybe_raises = contextlib.nullcontext()
with maybe_raises:
with com.temp_setattr(ser, "name", "second"):
...
Member
Author
There was a problem hiding this comment.
Good call! flake8 didn't like using pytest.raises outside a context manager; raising in either case made it a little simpler.
mroeschke
approved these changes
Feb 16, 2022
Contributor
|
thanks @rhshadrach |
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doesn't fix any user-facing bug (at least, that I'm aware of), but the current implementation will not restore the original attribute if an exception is raised within the context manager.