Skip to content

Conversation

@jonashaag
Copy link
Contributor

  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

@attack68
Copy link
Contributor

is there any discussion on this proposal and wider implications?

@jonashaag
Copy link
Contributor Author

It’s a follow up to #44817

@jonashaag jonashaag marked this pull request as ready for review January 27, 2022 20:00
@mroeschke mroeschke added Code Style Code style, linting, code_checks Dependencies Required and optional dependencies labels Jan 30, 2022
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Could you merge main one more time?

@mroeschke mroeschke added this to the 1.4.1 milestone Feb 6, 2022
@mroeschke mroeschke merged commit a63db3d into pandas-dev:main Feb 6, 2022
@mroeschke
Copy link
Member

Thanks @jonashaag

@mroeschke
Copy link
Member

@meeseeksdev backport 1.4.x

@lumberbot-app
Copy link

lumberbot-app bot commented Feb 6, 2022

Something went wrong ... Please have a look at my logs.

simonjayhawkins pushed a commit that referenced this pull request Feb 7, 2022
phofl pushed a commit to phofl/pandas that referenced this pull request Feb 14, 2022
yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Code Style Code style, linting, code_checks Dependencies Required and optional dependencies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants